Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: add tsc checker #54069

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

tools: add tsc checker #54069

wants to merge 4 commits into from

Conversation

1ilsang
Copy link
Contributor

@1ilsang 1ilsang commented Jul 27, 2024

Motivation

I've noticed that the declare files are not being checked(#54063, #54064) properly.

So I'd like to add lint for those files.

AS-IS

None

TO-BE

image
$ make lint-ts

If this PR is approved, I would also like to apply typescript-eslint(related #54065).

What do you think? thanks.

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Jul 27, 2024
@1ilsang 1ilsang force-pushed the feat/typings-lint branch from f5dce3f to 3b44b03 Compare July 27, 2024 15:17
@aduh95
Copy link
Contributor

aduh95 commented Jul 30, 2024

Let's not vendor typescript, the diff is unnecessary big.

@targos
Copy link
Member

targos commented Jul 30, 2024

Technically we already vendor TypeScript in https://github.com/nodejs/node/blob/main/test/fixtures/snapshot/typescript.js

@1ilsang
Copy link
Contributor Author

1ilsang commented Jul 31, 2024

image

tsconfig.json

image

@targos @aduh95 Hi.

Unfortunately, We don't have Typescript declare files, so we can't check the declare file.

image

Is this the way to do it? Any advice would be appreciated.

Here is example PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants